{Network} Bump to azure-mgmt-network 9.0.0#12078
Merged
haroldrandom merged 109 commits intoAzure:devfrom Feb 11, 2020
Merged
Conversation
haroldrandom
commented
Feb 7, 2020
Contributor
Author
There was a problem hiding this comment.
azure.mgmt.network.v2019_11_01.models._models_py3.ErrorResponseException: (UnsupportedStorageAccountVersionWithRetention) Storage /subscripti
ons/0b1f6471-1bf0-4dda-aec3-cb9272f09590/resourceGroups/cli_test_nw_flow_logfrumyb6ki53obj262ik24kxqlqatgydxxqj3sgia37ogd7jlcqxxdjq/providers/Microsoft.S
torage/storageAccounts/clitestnwenwnk7nks5dumov is a V1 storage account and with retention policy. Only V2 storage account are supported with retention p
olicy. Read more -> aka.ms/LogsHelp
Out of dated way to configure flow-log of watcher. There must be changes on service to restrict only V2 to configure a flow-log instead the original V1.
haroldrandom
commented
Feb 7, 2020
Contributor
Author
There was a problem hiding this comment.
azure.mgmt.network.v2019_11_01.models._models_py3.ErrorResponseException: (UnsupportedStorageAccountVersionWithRetention) Storage /subscripti
ons/0b1f6471-1bf0-4dda-aec3-cb9272f09590/resourceGroups/cli_test_nw_flow_logfrumyb6ki53obj262ik24kxqlqatgydxxqj3sgia37ogd7jlcqxxdjq/providers/Microsoft.S
torage/storageAccounts/clitestnwenwnk7nks5dumov is a V1 storage account and with retention policy. Only V2 storage account are supported with retention p
olicy. Read more -> aka.ms/LogsHelp
Out of dated way to configure flow-log of watcher. There must be changes on service to restrict only V2 to configure a flow-log instead the original V1.
Collaborator
|
add to S165. |
Contributor
Author
|
/azp run |
|
Pull request contains merge conflicts. |
added 23 commits
February 8, 2020 17:54
haroldrandom
commented
Feb 9, 2020
| accept-language: | ||
| - en-US | ||
| method: PUT | ||
| uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/NetworkWatcherRG/providers/Microsoft.Network/networkWatchers/NetworkWatcher_westcentralus/connectionMonitors/cm1?api-version=2019-06-01 | ||
| uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/NetworkWatcherRG/providers/Microsoft.Network/networkWatchers/NetworkWatcher_westcentralus/connectionMonitors/cm1?api-version=2019-11-01 | ||
| response: |
Contributor
Author
There was a problem hiding this comment.
FYI.
The API version is manually updated, and this is not a valid command's output.
Because some changes are made.
CMv1 is only allow to be created with api-version <= 2019-06-01, CMv2 is only allow to be created with api-version >209-06-01.
from now on, in this PR, only CMv1 is supported, CMv2 is at extensions, which will be brought in soon. So here manually update api-version to make it right.
haroldrandom
requested review from
Juliehzl,
bim-msft,
fengzhou-msft,
jaredmoo,
jiasli,
mmyyrroonn,
qianwens,
qwordy,
v-Ajnava and
zhoxing-ms
as code owners
mmyyrroonn
approved these changes
Feb 9, 2020
Contributor
|
@haroldrandom excellent work! I'd reconmend support CMv1 in this PR too so that we can keep our dev branch still functionalable. |
Juliehzl
reviewed
Feb 9, 2020
src/azure-cli/azure/cli/command_modules/sql/tests/latest/test_sql_commands.py
Show resolved
Hide resolved
fengzhou-msft
approved these changes
Feb 9, 2020
bim-msft
approved these changes
Feb 9, 2020
jaredmoo
approved these changes
Feb 10, 2020
zhoxing-ms
approved these changes
Feb 10, 2020
qianwens
approved these changes
Feb 10, 2020
jiasli
approved these changes
Feb 11, 2020
v-Ajnava
approved these changes
Feb 11, 2020
qwordy
approved these changes
Feb 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1st step to fix #9432. Which relies on azure-mgmt-network 9.0.0
History Notes:
(Fill in the following template if multiple notes are needed, otherwise PR title will be used for history note.)
[Component Name 1] (BREAKING CHANGE:) (az command:) make some customer-facing change.
[Component Name 2] (BREAKING CHANGE:) (az command:) make some customer-facing change.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.